Remove legacy GASNet-1 backend #25875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @PHHargrove @jhh67 |
PHHargrove
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
LGTM, @bonachea
Thanks for this effort to help reduce future maintenance overhead.
The legacy GASNet-1 backend has been superseded by the new GASNet-EX backend, which has been Chapel's default GASNet backend since 658ac15 (Chapel 2.1). Both backends run over the same GASNet-EX implementation, so this is mostly just about removing pointlessly duplicated Chapel runtime code, to improve future maintainability. Deliberately undocumented setting `CHPL_GASNET_VERSION` is also removed. Partially reverts 2f4776e Signed-off-by: Dan Bonachea <[email protected]>
Signed-off-by: Dan Bonachea <[email protected]>
bonachea
force-pushed
the
remove-g1-backend
branch
from
5471a47 to
0424ec2
Compare
|
I'll do it shortly. I'm currently in the process of removing the relevant jobs from our Jenkins server so they don't break. |
jhh67
approved these changes
Oct 15, 2024
bonachea
added a commit
to bonachea/chapel
that referenced
this pull request
Dec 4, 2024
Previously printchplbuilds.py was broken, probably by myself in chapel-lang#25875 Example: ``` $ ./util/chplenv/printchplbuilds.py Traceback (most recent call last): File "./util/chplenv/printchplbuilds.py", line 466, in <module> main(sys.argv) File "./util/chplenv/printchplbuilds.py", line 373, in main build = Parse(path) File "./util/chplenv/printchplbuilds.py", line 133, in Parse var = varNames[state] KeyError: <State.GASNET_VERSION: 11> ``` Signed-off-by: Dan Bonachea <[email protected]>
jabraham17
added a commit
that referenced
this pull request
Dec 6, 2024
Previously printchplbuilds.py was broken, probably by myself in #25875 Example: ``` $ ./util/chplenv/printchplbuilds.py Traceback (most recent call last): File "./util/chplenv/printchplbuilds.py", line 466, in <module> main(sys.argv) File "./util/chplenv/printchplbuilds.py", line 373, in main build = Parse(path) File "./util/chplenv/printchplbuilds.py", line 133, in Parse var = varNames[state] KeyError: <State.GASNET_VERSION: 11> ``` [Contributed by @bonachea. Reviewed and merged by @jabraham17]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The legacy GASNet-1 backend has been superseded by the new GASNet-EX backend,
which has been Chapel's default GASNet backend since 658ac15 (Chapel 2.1).
Both backends run over the same GASNet-EX implementation, so this is mostly
just about removing pointlessly duplicated Chapel runtime code, to improve
future maintainability.
Deliberately undocumented setting
CHPL_GASNET_VERSIONis also removed.Partially reverts 2f4776e
Manually tested on Perlmutter (ofi conduit) and JLSE Cascade (ibv and udp conduits).